search

niallsco / kettle-cookbook

Automatically exported from code.google.com/p/kettle-cookbook
GNU Lesser General Public License v3.0
1 stars 0 forks source link

ScriptValue and ScriptValueMod steps are not displayed the same #55

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Open "JavaScript - Access database connection metadata.ktr" in cookbook, 
Java Script icon does not appear but it appears in Spoon and script block does 
not appear
2. Open "JavaScript - Access environment variables.ktr" in cookbook, Java 
Script icon appears normal as it does in Spoon

What is the expected output? What do you see instead?
I would expect the icons to show up as it does in spoon.

The steps in the ktr files are different...
"ScriptValue" and "ScriptValueMod"
I believe "ScriptValue" is deprecated?

However Spoon is able to display "ScriptValue" steps

Original issue reported on code.google.com by herma...@gmail.com on 15 May 2013 at 5:07

Attachments:

GoogleCodeExporter commented 9 years ago 
This fixes the missing Icon for ScriptValue step

In line 639 of transformation.css
Originally
        .step-icon-ScriptValueMod,ScriptValue{
           background-image: url(../images/SCR_mod.png);
        }

Changed to
        .step-icon-ScriptValueMod{
           background-image: url(../images/SCR_mod.png);
        }

        .step-icon-ScriptValue{
           background-image: url(../images/SCR_mod.png);
        }

Original comment by herma...@gmail.com on 15 May 2013 at 5:27

GoogleCodeExporter commented 9 years ago 
This fixes the missing script block.

In kettle-report.xsl
Line# 573 - right after JsScript entry, add this

    <xsl:template match="script">
        <pre class="brush: js;"><xsl:value-of select="text()"/></pre>
    </xsl:template>

Around #780 - right after "JsScripts" entry
        <xsl:apply-templates select="script"/>

Original comment by herma...@gmail.com on 15 May 2013 at 5:31

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Feel free to make the change and commit to svn, I think these are good changes.

Original comment by roland.bouman on 15 May 2013 at 5:47

GoogleCodeExporter commented 9 years ago 
OK Done

Original comment by herma...@gmail.com on 15 May 2013 at 7:41

GoogleCodeExporter commented 9 years ago 
@hermandr, can I close this?

Original comment by roland.bouman on 29 May 2013 at 5:55

GoogleCodeExporter commented 9 years ago 
I was guilty for the bug on ScriptValue/ScriptValueMod:
with r80, I recreated transformation.css through ./constructor/Create_Files.kjb.

This with the intent to allow easy updates to new versions of kettle.
(Basically, the job transforms kettle-jobs.xml from the kettle source into 
tranformation.css) - in the hope to solve issue 40 with that.

But I didn't handle comma separated operators properly. This is fixed in r82.

Original comment by stefan.e...@gmail.com on 15 Jun 2013 at 1:21

GoogleCodeExporter commented 9 years ago 
Hi Stefan! 

Let's not talk about "guilty" or such terms. It just comes with the territory 
that work has unintended side effects.

Please help me out, I'm a little confused...Is this now fixed? If so, can you 
mark it fixed? Otherwise, let me know.

Original comment by roland.bouman on 15 Jun 2013 at 1:33

GoogleCodeExporter commented 9 years ago 
:-)
Consider it fixed - the .css is for sure ok.; I'm not sure what Herman needed 
the fix for in kettle-report.xsl, but he states it solves the problem too ...

Original comment by stefan.e...@gmail.com on 16 Jun 2013 at 12:05

GoogleCodeExporter commented 9 years ago

Original comment by roland.bouman on 16 Jun 2013 at 12:37

GoogleCodeExporter commented 9 years ago 
Stefan,

ScriptValue was not showing the "script" block.
The change in kettle-report fixes that.

Herman

Original comment by herma...@gmail.com on 16 Jun 2013 at 1:26

GoogleCodeExporter commented 9 years ago 
HI

we are using kettlecookbook_r45 to generate auto documentation of all 
jobs/transformation... but we are not getting complete documentation for ex. it 
is missing filter values and shell script details in HTML pages.

Can you please help me for this?
it is urgent

Original comment by manisha....@gmail.com on 20 Jul 2013 at 9:04

GoogleCodeExporter commented 9 years ago 
@manisha.kamble08,

could you please use svn checkout to get the latest version, and try that? Then 
please file a separate issue for any missing features. Please be sure to be 
specific about which steps aren't displaying as you'd like them. When in doubt, 
attach a sample transformation, and a screenshot of generated documentation 
that highlights the problem. If possible make a mockup of how you'd like it to 
be displayed.

Final note: please don't say it is urgent unless you're willing to contribute. 
This is a open source project which runs solely by the efforts of volunteers. A 
plea for urgency is rude and annoying.

Original comment by roland.bouman on 20 Jul 2013 at 9:14