docs: update contributing.md - Githubissues

niamurrell / value-app

Calculate the per-use value of purchases over time.

https://valuemax.herokuapp.com/

MIT License

12 stars 18 forks source link

docs: update contributing.md #25

Closed dangerjen closed 6 years ago

dangerjen commented 6 years ago

This PR updates the Contribution Guidelines to add a line telling the user to create a feature branch on their local repository.

What was a problem? (include issue # if applicable)

Updates issue #14

How does this PR fix the problem?

Updates the contribution guidelines.

Check lists (check `x` in `[ ]` of list items)

[x ] Changes were already discussed in issues (optional but please note here either way)
[ ] Meaningful commit messages
[ ] Code runs without any issues

Additional Comments (if any)

niamurrell commented 6 years ago

Thanks @dangerjen for the contribution! I've left out branching on purpose to keep contributing simpler for beginners.

I noticed you also got ride of some whitespace, etc. Did you use a code formatter? I was thinking of adding prettier to this project, maybe that's a PR you'd want to open?