nianeyna / ao3downloader

Utility for downloading fanfiction in bulk from the Archive of Our Own
GNU General Public License v3.0
201 stars 18 forks source link

Unable To Download Individual Fics From Collections #43

Closed ghost closed 2 years ago

ghost commented 2 years ago

Hello,nineyna! First and foremost, thank you so much for creating this wonderful program. I have 0 experience in programming and I really appreciate your instructions and this program in general. ( I sent an ask previously if this question is familiar to you.)

I have run into an issue while using it. I can't download individual stories from collections for example Big Bangs. If I include stories in a series, they are able to be downloaded, however the individual fics do not show up in the downloads folder.

I have tried deleting the settings, re-downloading the program itself. and I tried to see if the files were hidden but still nothing. I checked for this issue in several separate collections as well as tried to see if maybe my filters affected the download but the result is the same.

I have checked the logs and there is only the link of the collection listed but then no stories listed as being downloaded if I don't select to download from a series.

I don't have this issue if I am downloading from my favorites, from a creators page or from a works tag, just the collections.

I do not know if other people also ran into this issue or if it is just me. I understand if you do not have the time or if it is not possible to fix this issue but I wanted to bring this to your attention.

Thank you so much for making this awesome program! Me and my library are very grateful to you.

nianeyna commented 2 years ago

Hi! Thanks so much for reporting this issue. Can you provide a link to a collection that you tried to download where the problem occurred? This will help me to reproduce the issue on my own computer as close as possible to what you're experiencing.

ghost commented 2 years ago

Hello and thank you for such a quick response! I really appreciate it. I tried to download this collection as a sample without filters https://archiveofourown.org/collections/PaperLegends/works and the result was the same. I tried to download the first 2 pages for it without including series just so I could see if it would work the same.

I actually tried to download it with Python 10.5, too after using 10.6 before since I saw you mention it in another thread but it was the same result.

This is what it says in the log:

{"starting": "https://archiveofourown.org/collections/PaperLegends/works", "timestamp": "08/29/2022, 20:50:54"} {"starting": "https://archiveofourown.org/collections/PaperLegends/works?page=2", "timestamp": "08/29/2022, 20:50:56"}

Thank you so much for your help! I really appreciate it.

nianeyna commented 2 years ago

This is now fixed. The problem was that works linked from a collection page contain the collection name in the link, which didn't match the pattern I was using to identify work links. I've now updated that logic to properly recognize work links with collection prefixes. Thank you again!

ghost commented 2 years ago

Thank you so much for fixing this issue! Everything works fine now. I wish you all the best!