search

nianticlabs / simplerecon

[ECCV 2022] SimpleRecon: 3D Reconstruction Without 3D Convolutions
Other
1.3k stars 121 forks source link

Fix Project3D function #26

Closed gyes00205 closed 1 year ago

gyes00205 commented 1 year ago

Hi authors,

I fix the Project3D function of geometry_utils.py and the reason we can see issue#22. Original depth value are all greater or equal to eps because of torch.maximum, and this will make the mask in meta data all be True. Therefore, I fix the error and let this function return correct depth value.

mohammed-amr commented 1 year ago

Thanks for pointing this out. I've pushed changes that uses OpenCV and Kornia style normalization with eps.