search

niax / rust-email

Implementation of MIME Messages for Rust
MIT License
62 stars 34 forks source link

Switch to Results, and a bunch of nightly fixes #14

Closed untitaker closed 9 years ago

untitaker commented 9 years ago

This is work-in-progress. The test "test_address_list_parsing_groups" from src/address.rs is also currently hanging.

Fixes #7 Fixes #13

untitaker commented 9 years ago

The test fails now properly, but I still have no idea where the issue is.

untitaker commented 9 years ago

The bug has been fixed with https://github.com/niax/rust-email/commit/f0b8a82ad21c86729681a41ede4ba967ed3ee830, but I wonder how the tests could've passed before.

untitaker commented 9 years ago

I added a few helper functions to the base parser, I hope they're alright.

untitaker commented 9 years ago

Are you okay with removing all experimental tags? They don't exist anymore and I only get warnings.

untitaker commented 9 years ago

@niax After updating this PR for the latest nightly, it seems that Rust discourages having the tests in the same crate as the tested code. I've come to this conclusion because Rust wants me to use the test feature, yet the only place where I can do so is for the whole crate, which gives me an "unused feature" warning when compiling rust-email without tests.

niax commented 9 years ago

As it builds for now, let's consider where the tests are as a separate issue.

untitaker commented 9 years ago

Ok, cool. Maybe I'll provide more PRs regarding the error handling. I currently don't have the motivation for that though, this PR rather resulted out of the problem that email was breaking on nightly.

niax commented 9 years ago

This change has been included in 0.0.9 which has been published to crates.io