niax / rust-email

Implementation of MIME Messages for Rust
MIT License
63 stars 34 forks source link

Add encrypted multipart for MIME (RFC 1847) #51

Closed juga0 closed 4 years ago

juga0 commented 5 years ago

Closes #50.

dignifiedquire commented 4 years ago

Any chance this is getting merged? I could really use this

juga0 commented 4 years ago

@dignifiedquire i've not look to deltachat MIME [0] but i can imagine i could also use some features from it. So i think it would be great if deltachat could also help to improve this PR and/or this library with PRs.

[0] Not sure it's using https://github.com/deltachat/rust-email fork

azul commented 4 years ago

I'd be happy to help with this. @niax - it looks like your comment above has been addressed. What else is missing to get this merged? @juga0 - you said use help improving the PR. I had a quick look but did not notice anything obvious to work on. What would be needed from your point of view?

niax commented 4 years ago

Thanks a lot for pulling together this PR. I really want to make sure we build this in a way that's flexible beyond the encryption use case.

To that end, I've pushed bc85bf49af07744ce8e3aaac492efdfb7501b263 which adds support for the MIME types, along with setting the MIME type parameters.