search

nibblebits / PeachCompiler

A C compiler created for the how to create a C Compiler online course
GNU General Public License v2.0
83 stars 36 forks source link

function vector_resize_for_index (./helpers/vector.c) #5

Closed 1040403998 closed 1 year ago

1040403998 commented 1 year ago

while updating the parameter "vector->mindex", I think it should somehow be "vector->mindex = start_index + total_elements + VECTOR_ELEMENT_INCREMENT", instead of "vector->mindex = start_index + total_elements". I'm not sure if this is an issue or there is something wrong with my understanding. Please check for that.

nibblebits commented 1 year ago

Hello, Please can you elaborate n why you think this so i can see, use the code snippet feature if you dont mind so its easier for me to read

Thanks

nibblebits commented 1 year ago

Issue was closed for now, if you have more evidence of an issue please let me know