search

nibblebits / PeachOS

Simple kernel designed for a online course
GNU General Public License v2.0
133 stars 55 forks source link

fat16_load_fat_directory doesn't set starting sector #12

Closed JaihsonK closed 1 year ago

JaihsonK commented 1 year ago

We find the starting sector on line 540 (in PeachOS master), but we never set directory->starting_sector

nibblebits commented 1 year ago

Hello, There is no bug, directory->starting_sector is not used at the master. Please ensure if you are not already to only be making bug reports for the master branch because some issues were fixed in video content

Thanks,d Dan

nibblebits commented 1 year ago

If you do believe me to be mistaken please reopen with a deeper explanation with code from the master so it is clear Thanks for reporting it nevertheless

Thanks, Dan