search

nibblebits / PeachOS

Simple kernel designed for a online course
GNU General Public License v2.0
133 stars 55 forks source link

Push task real flags #6

Closed roginvs closed 1 year ago

roginvs commented 2 years ago

In task_return function we push values from kernel EFLAGS but we should push saved flags instead. Also this PR initialize flags for user program

nibblebits commented 1 year ago

Hi, I think that you are wrong. Thanks for this but we do not allow changes to this repository it is created in such a way it follows the video content therefore any commits that are not by me cannot be accepted.

Can you open an issue report instead and we can chat about why you think that this change is correct so we can figure out if their was a mistake or not. From first glance I think that you have got it wrong .

Thanks, Dan