Before the code PR is merged, please ensure that the following checklist is completed.
[X] Branch name details the work done for the PR
[X] CI tests have passed
[X] An admin has reviewed and accepted the PR
[X] Clang format has been run on changes (run ./tools/format.sh)
Please be sure that the code follows the style as follows:
Everything in snake_case
Classes end in _c (unless its an interface, then end in _if)
Structs end in _s
Unions end in _u
Enumerations end in _e
Type names that are redefined via using end in _t (always use using - not typedef)
Type names that define a particular type of pointer end in _ptr
The above is just a loose formatting that has been used already throughout the C++ source code of Nibi,
and we would like to keep things mostly uniform. In the future, an actual style guide may be created.
Description of work:
Please enter a description of your work here:
Flattened the cell_c object pretty substantially. Its about 1/2 the size it was before while maintaining the same functionality and still being 1-1 compatible with CFFI and no extra copies of data from C.
I removed all data stored in the `std::any` in the cell and flattened it into raw pointers within the c_data union. bench shows slight improvement but its realistically about the same .
What was once `complex_data` is no more!
(ﾉ◕ヮ◕)ﾉ✲ﾟ｡⋆ You've made a PR!
Before the code PR is merged, please ensure that the following checklist is completed.
run ./tools/format.sh)Please be sure that the code follows the style as follows:
snake_case_c(unless its an interface, then end in_if)_s_u_eusingend in_t(always useusing- nottypedef)_ptrThe above is just a loose formatting that has been used already throughout the C++ source code of Nibi, and we would like to keep things mostly uniform. In the future, an actual style guide may be created.
Description of work:
Please enter a description of your work here: