nibrahim / Hyde

An Emacs mode to manage Jekyll blogs
http://nibrahim.net.in/2010/11/11/hyde_%3A_an_emacs_mode_for_jekyll_blogs.html
GNU General Public License v3.0
117 stars 28 forks source link

Expand `home` before passing it on #3

Closed citizen428 closed 12 years ago

citizen428 commented 12 years ago

I'm not sure if it has something to do with my setup, but the version with expand-file-name works a lot better for me.

nibrahim commented 12 years ago

I can't see your change doing any damage. I'll check it out and merge it in. Thanks! However, can you tell me what errors you see without the expand-file-name?

citizen428 commented 12 years ago

I usually access my blog through a symlink pointing into my Dropbox folder (~/Projects is symlinked to ~/Dropbox/Projects). When I entered ~/Projects/blog after starting Hyde, there was an error message in the minibuffer that it can't cd into the directory, which disappeared after I expanded the file name. Seemed strange to me too.

nibrahim commented 12 years ago

I'll try it out and update the post.

citizen428 commented 12 years ago

Damn, sorry for the mess!

The last commit was supposed to be a second pull request, I forgot this one was still open. I basically added a variable called hyde/use-octopress, which I set in my .hyde.el with hyde/use-octopress t. I think it could be useful for customizing certain steps for use with Octopress, e.g. I modified hyde/new-post so that t it can create the same file header as rake new_post would.

nibrahim commented 12 years ago

Do you think that's a good idea? I'd prefer that we put in something like hyde/new-post-command or something that can be customised so that in the future, this will still work for other jekyll based systems (and not just Octopress). Basically, I don't want to tie it down to a single project.

citizen428 commented 12 years ago

Fair enough, I just did the quickest thing that worked for me right now. The hyde/new-post-command idea sounds good. How do you want to implement it? Have it default to the current hyde/new-post and allow users to override it from the configs?

nibrahim commented 12 years ago

Exactly.

citizen428 commented 12 years ago

I'll try to implement this in the coming week. I'll also close this pull request, it's rather useless by now (except maybe for the expand-file-name thing).