[WIP] Added twig extension

nibsirahsieu / SalvaJshrinkBundle

NOT MAINTAINED - This bundle integrate jshrink library as Assetic filter and twig extension

MIT License

32 stars 6 forks source link

[WIP] Added twig extension #1

Closed snc closed 11 years ago

snc commented 11 years ago

This PR adds support for twig. It can be used like the {% spaceless %} extension.

Example:

<script type="text/javascript">{% jshrink %}
    $(document).ready(function() {
        // ...
    });
{% endjshrink %}</script>

What needs to be done?

composer.json needs to be adjusted
configuration parameter to enable/disable the extension (and or assetic filter?)

nibsirahsieu commented 11 years ago

:+1:
Thanks for this cool PR.

Commenting your second To-do : Do we really need the 'toggle' to on/off the extension? i think everyone will happy with this feature :)

snc commented 11 years ago

The toggle is optional I think :-)

nibsirahsieu commented 11 years ago

So, this is mergeable now? i'm going to update composer.json and README files

snc commented 11 years ago

Yes, it's mergeable if you do the composer.json and README updates. Don't forget to edit the GitHub description This bundle integrate jshrink library as Assetic filter ;-)

nibsirahsieu commented 11 years ago

merged, thanks.

snc commented 11 years ago

:+1: