search

nibsirahsieu / SalvaJshrinkBundle

NOT MAINTAINED - This bundle integrate jshrink library as Assetic filter and twig extension
MIT License
32 stars 6 forks source link

No shrinkage in debug mode #6

Closed artursvonda closed 9 years ago

artursvonda commented 9 years ago

Having enable: %kernel.debug% in config would be nice to disable jshrink in debug mode.

EmanueleMinotto commented 9 years ago

If you mean in Assetic you can disable it just prepending a ? to the jshrink filter (ref). Or do you mean in the Twig extension too?

artursvonda commented 9 years ago

I mean extension should take that into account too.

Sent from my iPhone

On 2015. gada 28. janv., at 17:50, Emanuele Minotto notifications@github.com wrote:

If you mean in Assetic you can disable it just prepending a ? to the jshrink filter (ref). Or do you mean in the Twig extension too?

— Reply to this email directly or view it on GitHub.

artursvonda commented 9 years ago

Thanks for merging this! Will you, please, bump version?

EmanueleMinotto commented 9 years ago

Sure, I'll wait 1 or 2 days to receive some feedbacks but after these imo a v1.1.0 can be released.

EmanueleMinotto commented 9 years ago

Done, thank you for the PR :)