search

nibuen / SpaceAlertMissionGenerator

Mission Generator For Space Alert Board Game On Android
https://blog.iterary.com/
MIT License
15 stars 9 forks source link

Adds option to restore default values in options screen #11

Closed tompen closed 10 years ago

tompen commented 10 years ago

Adds options to restore default values in options screen. Clarifies title to show that the setting only affects random missions. Moves the setting "Log Colors" to a separate group since this setting affects all missions, not just random missions.

tompen commented 10 years ago

I have always been a little reluctant to change anything in the options screen, since I was unsure if I was going to be able to go back to the default values. So I think a restore default values option would be valuable.

I can get the german translations if you like the changes.

nibuen commented 10 years ago

Going back to default values should work fine since We basically pull the preferences on start of mission. Might need to make sure there isn't an awkward state on pause though that has people thinking they changed the settings, when it really is still on old.

Personally unit tests for that kind of stuff would be great, but if not enough time for that just play with it.

tompen commented 10 years ago

Going back to default values should work fine since We basically pull the preferences on start of mission. Might need to make sure there isn't an awkward state on pause though that has people thinking they changed the settings, when it really is still on old.

Would that not be same as if the user opens the option screen when a mission is already running and changes the values manually?

Personally unit tests for that kind of stuff would be great, but if not enough time for that just play with it.

I will check unit tests out.

Btw: I just found that my change that I uploaded causes a crash. There is no need for you to download and test the changes before I have fixed this problem.

nibuen commented 10 years ago

Yea it would be same path hopefully though not sure how sound that path is. 8)

Actually if memory serves correctly it doesn't update the current mission till a new one is generated. I am fine leaving that way it is, but if you think of something better I am game.

Thanks for heads up.

tompen commented 10 years ago

My github-skills are not very good, so my changes ended up in a new pull request: https://github.com/nibuen/SpaceAlertMissionGenerator/pull/15

I will continue the discussion there.