nibuen / SpaceAlertMissionGenerator

Mission Generator For Space Alert Board Game On Android
https://blog.iterary.com/
MIT License
15 stars 9 forks source link

Adds option to restore default values in options screen #15

Closed tompen closed 4 years ago

tompen commented 10 years ago

Adds options to restore default values in options screen. Clarifies title to show that the setting only affects random missions. Moves the setting "Log Colors" to a separate group since this setting affects all missions, not just random missions.

tompen commented 10 years ago

True. I will remove the null check.

Done

Init functions aren't a big deal so go with that, just usually try and avoid them due to how they can be misused.

Function renamed to initRestoreDefaultButton, and comments have been improved to clarify what it does.

Actually if memory serves correctly it doesn't update the current mission till a new one is generated. I am fine leaving that way it is, but if you think of something better I am game.

I have actually been tricked by the application once. After we had run two missions we realized that it was the same mission had been run twice, and that the changes I had done in the setting screen had not taken effect. I had pressed restart mission, instead of new mission. I think there is room for improvement regarding this.

Btw: I just found that my change that I uploaded causes a crash.

There is a bug where the min and max values was mixed up. I am working on a fix.

tompen commented 10 years ago

There is a bug where the min and max values was mixed up. I am working on a fix.

I have made a first attempt to solve this problem. I am not done with it. More testing is required.

nibuen commented 9 years ago

Any luck on finishing this?

tompen commented 9 years ago

I did not finish it. However, I will take a new look.

Thanks for reminding me.

nibuen commented 9 years ago

Sounds good. I am planning a release in about a week. Should hopefully get some of the more annoying things out of the way: communication down bug, icon on 5.0, etc.

tompen commented 9 years ago

Unfortunately I have not had any progress.

I upgraded to Android Studio 1.0 RC 1, and then I ran into problems with the build files which I did solve.

nibuen commented 9 years ago

No rush, was just checking if you had something. Please sync with master and project should work with 1.0