search

nibuen / SpaceAlertMissionGenerator

Mission Generator For Space Alert Board Game On Android
https://blog.iterary.com/
MIT License
15 stars 9 forks source link

Cancels notification when mission is paused #25

Closed tompen closed 9 years ago

tompen commented 9 years ago

Cancels the notification in the status bar when a mission is paused.

tompen commented 9 years ago

Hi!

What do you think of this change? I think the current behaviour is a little to intrusive. Once the user has started a mission there will be a permanent sticky notification in the status bar. It is sticky, so the user does not have the ability to dismiss it. The notification will remain even after the mission is completed. The only way I have found to dismiss the notification is to kill the app.

My suggestion is to only show the notification while a mission is actually running. Any thoughts?

nibuen commented 9 years ago

Looks good.

nibuen commented 9 years ago

I realize now why it was done this way. It is needed for android wear app. Also useful if you are just pausing from notifications and not watching app. I have reverted change on main branch.

I think we can take an idea from other apps like pandora though and add an x in the corner to kill the notification and application.

tompen commented 9 years ago

Sure!

I suspected the current behavior was done for a reason. We just have to find a better way of doing it.