Closed kuhrusty closed 4 years ago
Thanks! I did have to retheme everything with the upgrades, so thought I might miss a few passes,, lets get your stuff merged and then will do some extensive testing as well
I think also it was cause my phone is in dark mode theme... need to check for more consistent compatibility on that
lets get your stuff merged
OK, should be sending a PR in the next hour or so.
The short version: if you select a mission with an introduction (one of the double-action missions), the introduction is displayed with black text on a black background. (If you're not seeing this, I can add a screen capture.)
The long & boring version: when I merged the
circleci-project-setup
changes into my issue #28 changes, the app didn't look right, & I assumed this was because I'd goofed up one of the conflicts. So, on my box, in a new clone of my fork, I did this:Then I created a branch at the point where I originally forked it, and merged your master into that:
That fast-forwarded everything. Now my issue28-merge branch should be identical to your master; that branch is what I built out of. (I figure I'll manually merge my issue #28 changes into there, and then do a PR from there.)