search

nibuen / SpaceAlertMissionGenerator

Mission Generator For Space Alert Board Game On Android
https://blog.iterary.com/
MIT License
15 stars 9 forks source link

better double threats and more appropriate data transfers for double actions #55

Open slinkymanbyday opened 1 year ago

slinkymanbyday commented 1 year ago

Apologies for large single commit. You you want I can break it down into smaller commits. Will still play test this a bit the next change a get (normally play every few weeks). I only play double action missions, however I think my changes should be ok for single action missions too.

slinkymanbyday commented 1 year ago

In regards to German translation, I used Google translate, can be updated with someone who knows German

nibuen commented 1 year ago

Please look at adding tests for this is important for sanity, and yea it would help to do the refactor separate from the changes you want so we can have more sanity if we need to rollback... not sure what is going on with circleci build... I think I will try and move to github actions now that open source has some free credits

nibuen commented 1 year ago

Also I can't fully tell from what you have done, but are you considering the swap between normal missions and double actions configurations? My thoughts is it should reset to expected ranges as you swap between them

slinkymanbyday commented 1 year ago

My thoughts is it should reset to expected ranges as you swap between them

This would be nice, but i'm not sure how to accomplish that.

nibuen commented 1 year ago

My thoughts is it should reset to expected ranges as you swap between them

This would be nice, but i'm not sure how to accomplish that.

No worries, I can help with that, you inspired me to work on finishing the move to coroutines as well so will maybe get this code base cleaned up and have it more obvious when random missions are generated as well =)