search

nic-delhi / AarogyaSetu_Android

Aarogya Setu Android app native code
https://www.aarogyasetu.gov.in/
Other
2.89k stars 1.96k forks source link

[Meta issue] Code improvements #480

Open gaurav414u opened 4 years ago

gaurav414u commented 4 years ago

I have 2 things in my mind regarding the code improvements. Before I start working, would like to get an opinion from the community here.

  1. Code style: We should enfore java and kotlin code style using some kind of gradle plugin. The one I know of is https://github.com/diffplug/spotless/tree/main/plugin-gradle.

    • This will make sure all the coding style is consistent. The beauty of spotless is that it automatically formats the files as per the recommended google java/kotlin style.

  2. Kotlin only I can see a couple of classes in java/kotlin. Lets move to kotlin only?

    • Will help the devs to remain focus and less context-switch.

Questions regarding contribution guidelines! Whom do I need approval from before I start working on the changes? Pull requests should be sent against master or a new/dev branch?

gaurav414u commented 4 years ago

Also, do we have a discord/slack channel for the active contributors?

gaurav414u commented 4 years ago

@chandrapal-yadav @niharika2810 fyi!