search

nic-dgl104-winter-2024 / pattern-library

A multi-language library containing implementations of common software design and architecture patterns
4 stars 37 forks source link

Add implementation of MVVM in Javascript #58

Closed ting-dev-coder closed 6 months ago

ting-dev-coder commented 6 months ago

Status

Done

Description

Add implementation / description of model view viewmodel (MVVM) #15 I haven't written anything for the README.md as it seems to be included in another issue, #25.

Breaking Changes

No

Type of Change

📝 Code

ash-teach commented 6 months ago

Great work, @ting-dev-coder. I've requested some very minor changes; however, I think more could be done on this documentation-wise. You've used a lot of clever and modern techniques that won't be familiar to everyone (I've been out of the JS ecosystem for a few year, so there are a few things that I didn't recognize right off!)

I think once you make those minor changes we'll merge, but then I will open a few more issues relating to creating documentation. Since there is a lot going on in this implementation, it might give some folks who haven't had a chance to contribute an opportunity to help out.

ting-dev-coder commented 6 months ago

@ash-teach Done with modifications based on the above suggestions! I agree! Some of them require some time to connect each logic, and that's why I feel like reading source code could give a boost to a developer!