nic-dgl104-winter-2024 / pattern-library

A multi-language library containing implementations of common software design and architecture patterns
4 stars 37 forks source link

Add Prototype patters and contribute with issue #26 #76

Closed mijuanmontalvo closed 5 months ago

mijuanmontalvo commented 6 months ago

To contribute with issue #26, I did this:

In the "1. Creational Patterns" section table of the README.md file in the "patterns" folder add a link to the word Prototype, so that when users click, it will take them to the "Prototype" pattern folder

Inside the "patterns" folder I created a folder called "Prototype" (the folder indicated in the previous paragraph).

Inside the "Prototype" folder I created two files "README.md" and "Prototype.js".

In the "README.md" file I have placed a definition of the prototype pattern and an explanation of an example of this type of pattern for javascrip.

In the "Prototype.js" file add the example code of the prototype pattern for javascrip

ash-teach commented 6 months ago

Thanks @mijuanmontalvo - lots of great work here. I think there are some improvements to be made, especially relating to the nature of prototypes in JavaScript. I've asked for some fixes in the comments above - you may not be able to address them all at this late stage, but do your best. If you need help, feel free to request it from others. If you need help prioritizing the tasks listed in the review comments, just let me know.

mijuanmontalvo commented 6 months ago

Hello @ash-teach, how are you,

Please review your comments on this pull request and make the following changes:

All the previous items were made in my "main" branch so I understand that those changes are automatically reflected in this pull request. Please review these changes, thank you very much