nic-dgl104-winter-2024 / pattern-library

A multi-language library containing implementations of common software design and architecture patterns

4 stars 37 forks source link

Add PHP Singleton pattern #43 #83

Closed michiwo1 closed 7 months ago

michiwo1 commented 7 months ago

Related Issue

43

Description

Added a description of the PHP Singleton pattern to the readme. I also wrote code examples in the php file.

michiwo1 commented 7 months ago

Update 1

Details

I have updated the method to ensure a safer way to query data, thereby mitigating the risk of SQL injections.

comment: https://github.com/nic-dgl104-winter-2024/pattern-library/pull/83#discussion_r1538076870
commit: 8e2d17072a0391e24f96838aed96aacb8e23c0bb
Refactoring of some code was performed
comment: https://github.com/nic-dgl104-winter-2024/pattern-library/pull/83#discussion_r1538085252
comment: https://github.com/nic-dgl104-winter-2024/pattern-library/pull/83#pullrequestreview-1958521398
commit: 33143430f1bb7c3a1bd6a9d0c5f6dd10ea37e60a
commit: 15c86a2be067adb877d7fc1579dff24e0689dd89
Added findOrFail method
comment: https://github.com/nic-dgl104-winter-2024/pattern-library/pull/83#pullrequestreview-1958521398
commit: a15f362da06ab553cd3dc3c8229b5a2d3a258ed9

michiwo1 commented 7 months ago

Hi @Dhuds1, Thanks for doing your review! I have fixed some of your points and added some of your ideas as well. I hope you will review it again when you have time. The following is a comment summarizing what has been fixed. https://github.com/nic-dgl104-winter-2024/pattern-library/pull/83#issuecomment-2019027613

Dhuds1 commented 7 months ago

Looks great! I don't see anything else to comment on!

ash-teach commented 7 months ago

Thanks @michiwo1 and @Dhuds1!