search

nic-dgl104-winter-2024 / pattern-library

A multi-language library containing implementations of common software design and architecture patterns
4 stars 37 forks source link

Add java code implementation example of template pattern #90

Closed Jessica-Pelletier closed 5 months ago

abhiram-shaji commented 6 months ago

Hi Jessica, this looks pretty impressive and well explained. However, I would like to point out an issue with your package name. In Java, package names are written in all lower case to avoid conflict with the names of classes or interfaces. Also, I think you named it 'observal' instead of 'template' by mistake.

Jessica-Pelletier commented 6 months ago

Hi @abhiram-shaji Thanks for looking this over for me! I see these issues now. The package name auto filled for me because of the file structure. Do you think it makes sense to simply change the package name from patterns.Behavioral.Observal.Java -> patterns.behavior.template.java? I may have to look into this further.

abhiram-shaji commented 6 months ago

Thanks for looking this over for me! I see these issues now. The package name auto filled for me because of the file structure. Do you think it makes sense to simply change the package name from patterns.Behavioral.Observal.Java -> patterns.behavior.template.java? I may have to look into this further.

That definitely seem to be more suitable package name

ash-teach commented 6 months ago

Great work, @Jessica-Pelletier. I've noted a couple minor fixes above, if you can address them.

Jessica-Pelletier commented 6 months ago

Changes have been made ! I got a little confused in the process of pushing my branch of my fork. Hopefully it's all good.