search

nic-dgl104-winter-2024 / pattern-library

A multi-language library containing implementations of common software design and architecture patterns
4 stars 37 forks source link

Contrast functional patterns vs. OOP design patterns in README.md #27 #92

Closed mrsaif888 closed 7 months ago

BasranS commented 7 months ago

The readme file explains two ways of writing code: functional programming and object-oriented programming (OOP) with examples in Java which is very informative. I have some suggestions for your work, to enhance its understanding and readability, explain how functional and OOP are different by talking about their usage. Also, make sure the formatting is consistent.

ash-teach commented 7 months ago

Thanks, @mrsaif888. I think your examples are a good addition to what @Sumit-tech-joshi has already completed. Especially if, as I suggest above, you add a complete example for the map-filter-reduce pattern.

However, I think it would be be better if you integrate some of what you've written here into the main README file, where Sumit has included his work. That would cut down on the repetition of content (notice in the comments above I have suggested cutting out some content instead of moving it all over), and would keep all related material in one place.

mrsaif888 commented 7 months ago

@ash-teach i have merged all my contribution in the main readme file and make changes as you asked to do

ash-teach commented 7 months ago

The content you've written is on the right track, but I will not merge this for two main reasons:

  1. There are many Markdown errors that are causing some poor formatting. Merging this PR would cause some significant problems in the README.
  2. You did move your content to the main README as requested; however, I expected that you would integrate it with the existing Functional section, rather than writing a whole new section.

Even though I'm not merging content the record of your work will remain in this [closed] PR.