search

nicHoch / tca

app bug reporting
3 stars 0 forks source link

Grade filter does not consider local grade context #119

Open killakalle opened 3 years ago

killakalle commented 3 years ago

What happened?

  1. Go to a boulder area
  2. Go to Search
  3. Go to Route list
  4. Start filtering by grade

The grades of the result list do not match the filter.

Apparently the Slides goes by FB (sport climbing) whereas the routes are shown and filtered by FB (bouldering). The difference is more subtle in Europe. However, when you go to other places in the world with different grade context, it becomes more obvious

Example url(s) to reproduce the problem:

Ideally also provide screenshots:

In Europe it's confusing because both grade context look the same image

In Australia the difference is obvious image

What you expected:

rouletout commented 3 years ago

Fixed, closing

killakalle commented 2 years ago

@rouletout This is not fixed. The behavior looks still the same. Please, re-open this issue.

bkucsera commented 2 years ago

For the grade problem we can have a comprehensive solution with the upcoming Profile features, however new questions arise. In this new Profile system, the users will be able to set their default grade system. Once they set, every grade will appear in that grade system in the app. Further questions with this solution:

scd commented 2 years ago

An area can contain boulder and sport routes as direct children.

On the website we use the concept of grade context. This is a set of unambiguous local grading systems. We only show the label for systems outside the context.

Most climbers will be using the app mostly on local crags, so I think it is better to keep the UI uncluttered for them.

Please note that months of work have gone into the grades solution on thecrag so it would be best to piggyback on that as much as possible.

On Tue., 19 Oct. 2021, 11:29 pm bkucsera, @.***> wrote:

For the grade problem we can have a comprehensive solution with the upcoming Profile features, however new questions arise. In this new Profile system, the users will be able to set their default grade system. Once they set, every grade will appear in that grade system in the app. Further questions with this solution:

  • what happens if a node (area, crag, etc) contains boulder and sport routes? Can it happen or these are always showed in a different list?
  • We should bring back the the tags to the grade, to make it clear for the users, if they see a font_french or lead_french grade. What do you think about this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/theCrag/tca/issues/119#issuecomment-946672821, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC3CQVYZPDQVUQ7QR3QKXDUHVQDFANCNFSM44DOEDIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

bkucsera commented 2 years ago

The goal is to have the best user experience. I think one part of users want to see the grades in the original/local grade context, other group of users want to see in their preferred grading system. For example, if a european climber goes bouldering to the USA, maybe wants to search for boulders around 7a, not V6.

So, other solution can be to add a grade type changing possibility to the Search tab.

What if we put a switch button on the Route search tab? The user will see the search list in the local grade context, but can switch to the preferred grading system (what is set in the user's Profile).

What do you think about this solution? @killakalle @rouletout

rouletout commented 2 years ago

Sounds good - this is what we have on the web with the "Convert" button.

rouletout commented 2 years ago

+1 from support