nicHoch / tca

app bug reporting
4 stars 0 forks source link

iOS: Slash grades not displayed correctly #133

Closed rouletout closed 2 years ago

rouletout commented 3 years ago

What happened?

For example here: https://www.thecrag.com/de/klettern/mexico/area/2682816909 there is a route (number 11) that has a grade of 5.12a/b but it is displayed as 5.12a. The color coding is correct but the grade is wrong.

Ideally also provide screenshots: image

What you expected:

Correct display of slash grades.

rouletout commented 2 years ago

I raised that to fix for next release as it gives wrong grade info - @bkucsera

bkucsera commented 2 years ago

As discussed before, we do it in the next live release, together with android.

bkucsera commented 2 years ago

Here is a solution-suggest, please review the idea:

This way we do not loose to much on UX, with too long grades. What do you think, is it a good solution? Any other ideas? @rouletout

rouletout commented 2 years ago

I think acceptable even though it is not the best way to inform a user about a grade - can we add 3 dots to a slash that is too long so that it is clear that there is more to it?

bkucsera commented 2 years ago

So add 3 dots in every time when it is a slash grade? Or just in those cases, when it would be longer than 2 characters? By the way we can decide to show the slash grades in every cases, independently of how long is it. But in this case the route name can be cut.

In those cases when we cut the route name because its longer than the available space, we will make rolling route names on iOS as well, as we have it on android now.

rouletout commented 2 years ago

I would just do it if we can't put the full slash grade. Displaying grades correctly is "safety critical" so we are pretty careful with that in general. I think the grade is more important than the full name :-) - so if you can do thge rolling anme even better...

bkucsera commented 2 years ago

Slash grades fixed, please check.

rouletout commented 2 years ago

Looks good, closing