search

nicHoch / tca

app bug reporting
4 stars 0 forks source link

Topo: route list displays same route twice #163

Open rouletout opened 2 years ago

rouletout commented 2 years ago

What happened?

For example here: https://www.thecrag.com/de/klettern/mexico/area/2649717507 the app shows the first route twice but the web shows it correctly.

IMG_8004

IMG_8005

Ideally also provide screenshots:

What you expected:

Correct display of routes.

killakalle commented 2 years ago

@rouletout

If you edit the topo on the website, the route does show twice there, too.

image

rouletout commented 2 years ago

@scd can you look into that briefly?

scd commented 2 years ago

Note to self, english version of page:

https://www.thecrag.com/en/climbing/mexico/area/2649717507

scd commented 2 years ago

Hmm, there is. a dup route in the data. I tried deleting and putting back using our UI and it puts back the dup field. I suspect that somehow the system got the dup field (eg a merge) and the UI assumes that when deleting there is only one route. I think the route link is soft deleted.

This needs further investigation

scd commented 2 years ago

For some reason we have two active set of points drawn on one route. The system only ever assumes one. Next I have to work out what to do about it.

mysql> select * from TopoRoutePoints where TopoRoute=2656170321\G
*************************** 1. row ***************************
  CreateDate: 1564980778
 RecordOrder: 15649807780000
          ID: 2656175184
   TopoRoute: 2656170321
  ActiveFlag: 1
     SVGPath: NULL
   CreatedBy: 2649603096
ReviewedFlag: 0
      Points: 6.3 299.8,2.1 262.4
   UpdatedBy: 2649603120
RecordStatus: 1
 LastUpdated: NULL
*************************** 2. row ***************************
  CreateDate: 1564980779
 RecordOrder: 15649807790000
          ID: 2656175232
   TopoRoute: 2656170321
  ActiveFlag: 1
     SVGPath: NULL
   CreatedBy: 2649603096
ReviewedFlag: 0
      Points: 6.3 299.8,2.1 262.4
   UpdatedBy: 2649603120
RecordStatus: 1
 LastUpdated: NULL
2 rows in set (0.00 sec)
scd commented 2 years ago

I have made a fix to the topo route linking and unlinking so that it deals with historical inactive lines and only pick the latest when relinking.

After the next release unlink the route and relink the route and the topo line should come back without duplicates.

bkucsera commented 2 years ago

Fixed as we see, please check.