Area topo lists area that is not linked

[killakalle]

What happened?

1. Go to Bellus-Alboy / Altet
2. Look at topos

There are three areas in the area list, although only two areas are really linked to topo

Example url(s) to reproduce the problem: https://www.thecrag.com/es/escalar/spain/bellus/area/2024002464

Ideally also provide screenshots:

What you expected:

• [ ] Only areas shown in list, that are actually linked to topo

[bkucsera]

We also had this is a previous issue. The reason of this behaviour is that in a previous version of the topo probably "Sol" was also added to this topo image. Because of this, the api sends the following data: [ "Area", 2024008644, "312.6 127.1 lbvnd Estiu%20desplom,482.5 221.9,482.5 127.1,312.6 127.1,312.6 221.9", 2024002464, 4 ], [ "Area", 1643594358, null, 2024002464, 2 ], [ "Area", 2024008017, "92.5 147.8 lbvnd Estiu%20placa,92.5 266.5,92.5 147.8,274.4 147.8,274.4 266.5", 2024002464, 3 ]

Here you can see the that the second Area (which is Sol) has a null parameter, this is why we dont see it on the image.

Two possible solutions: Harder: clear out the database of this "null" infos. This would be better on long-term. Easier: we can delete all the data from the listing, where we get a null parameter. This solution means an overhead in the app, as we have to check one more parameter at every api call = slower working of the app.

The best would be to exclude the null parameters from the api. This way the app can get clear data, which means faster working.

Please send us a feedback, which solution should we implement. @rouletout

[scd]

I think it would be simple to have an API Param which tells the end point to exclude records with null.

On Tue., 19 Oct. 2021, 11:21 pm bkucsera, @.***> wrote:

We also had this is a previous issue. The reason of this behaviour is that in a previous version of the topo probably "Sol" was also added to this topo image. Because of this, the api sends the following data: [ "Area", 2024008644, "312.6 127.1 lbvnd Estiu%20desplom,482.5 221.9,482.5 127.1,312.6 127.1,312.6 221.9", 2024002464, 4 ], [ "Area", 1643594358, null, 2024002464, 2 ], [ "Area", 2024008017, "92.5 147.8 lbvnd Estiu%20placa,92.5 266.5,92.5 147.8,274.4 147.8,274.4 266.5", 2024002464, 3 ]

Here you can see the that the second Area (which is Sol) has a null parameter, this is why we dont see it on the image.

Two possible solutions: Harder: clear out the database of this "null" infos. This would be better on long-term. Easier: we can delete all the data from the listing, where we get a null parameter. This solution means an overhead in the app, as we have to check one more parameter at every api call = slower working of the app.

The best would be to exclude the null parameters from the api. This way the app can get clear data, which means faster working.

Please send us a feedback, which solution should we implement. @rouletout https://github.com/rouletout

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/theCrag/tca/issues/164#issuecomment-946666335, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC3CQSXLRWGEPZBHWBPNR3UHVPD3ANCNFSM5GDRQQQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[bkucsera]

Ok, please add this to the API and let us know when you are ready, so we can change it on the app side as well. Thanks!

[scd]

I have implemented url paramenter to exlcude null topo lines. Use omitNullTopoLines=1

Note that this will be available next release. It is not hotfixed.