nicHoch / tca

app bug reporting
4 stars 0 forks source link

global search only search in last visited crag #65

Closed nicHoch closed 3 years ago

nicHoch commented 3 years ago

reproduce: example https://thecrag.topoguru.com/info/12495061

image

bkucsera commented 3 years ago

You can switch to the global search with the "globe" icon on the right side of the search bar. Do you have any suggestions, how to make it more clear for the users?

nicHoch commented 3 years ago

ahh ok. hmm not very self explaining - but i have also no better idea. But if the user leaves an crag and is going back to the map - it would be helpful to automatically trigger that option.

andrasbari commented 3 years ago

<-- 400 Bad Request https://www.thecrag.com/api/facet/areas/at/7546063/of-area-type/region/search/aus?perPage=100&page=1&minobject=1&pretty=0&key=abc123 The World's node id is 7546063. We have got HTTP 400 error code for response. I think it caused by the limitation of our api key. @scd

bkucsera commented 3 years ago

We try something more visible, probably an animation on the globe button.

rouletout commented 3 years ago

wow, never tried this before but failed epically to find anything. Even clicking on the globe doesn't help me to find zillertal or kufstein. i simply don't get anything. How is this supposed to work?

bkucsera commented 3 years ago

If you click on the globe icon to switch it to blue color, the search still doesnt work for you? I attached a screenshot from my device.

Screenshot_20210318-150319_Topo Guru.jpg

nicHoch commented 3 years ago

i have seen the new animation on the "global" icon. But i do not think that this is solving the main issue here.

The search is only available from the map page what i interpret as some kind of world level.

If i click right away on the search icon (what is do not interpret as a search icon should be a magnifier and not the "menu" icon) from the map (word level) i really expect that i can search all areas - what it does - good.

But If i select a crag from the map and "enter" this crag. I have no chance to do a proper search besides the route search in the "routes" tab. if i want to search within this crag i have to go back to map (world level) and open the search there. Now it suddenly the app remembers my last crag and only searches there. This is totally unexpected behavior.

I would suggest to make that search also available from within a crag page - from there the search should only search in the subtree. But the search available from the map should always search on country level (or maybe later on only on the map view box - i guess this is a bit more sophisticated and can wait fro a later release)

rouletout commented 3 years ago

@bkucsera I think I understood how it works but I tried to search for "säli" and I only get 1 route and no areas, can you check that?

killakalle commented 3 years ago

If it's of any valuable input:

Some UX feedback To me the search is one of the most important functionalities in theCrag. I use it all the time (on the website) to go to different crags or to find a route. When I open the app at the moment, I don't see the search functionality. However, it seems that from anywhere in the app I can go to my profile. I hardly ever need to go into my profile and look up my user name. I'd be happy to do 2-3 clicks to see my profile details. However, the search is super essential. It should be accessible all the time from everywhere

killakalle commented 3 years ago

PS: Why don't you put the search here? I don't think I need to see the big Topo Guru / the Crag label all the time. I know that I am using the app, the space would be better used with functionality that I need image

Take a look at Google Maps for example. It doesn't say "GOOGLE MAPS" anywhere. But the Search box is very prominent

bkucsera commented 3 years ago

The "list" icon going to be changed on the World Map view to a "search" icon, in the upper right corner. We can do modifications later to improve Search, lets check the first version with this solution.

bkucsera commented 3 years ago

Fixed (v151), please check and close if works properly.

rouletout commented 3 years ago

Search is now by default global which is nice. I have 2 things that (still) confuse me:

1) Now when I click search in an area it obviously searches only in that area which makes sense. But how do i search globally from there? Right now I have to click "back" (arrive on the map), click back again (arrive on area page), click back again (arrive on the map with the area selected), click search on top right - now I can finally search globally - I think there should be a shorter way

2) Once I open global search, I see a list of results starting with "Livingston Island", North Pole, etc.... - shouldn't this be empty?

@bkucsera please check / comment

nicHoch commented 3 years ago

the "local" search is not so user friendly at the moment. the grade filter (slider) triggers a tab swipe. and does not filter the routes on the fly. also open the keyboard and press the search icon does not update the route list according the grade filter.

furthermore i would propose that the "route tab" within the local search is pre-selected if there are routes. for filtering routes what might be the most common local search you have to switch to the "route-tab" first. also it looks like that the route search is using an api call. but the on devise instant filtering while typing would be more offline friendly and faster. as the data is already available. you can trigger a api search if in the soft keyboard the looking glass is pressed.

nicHoch commented 3 years ago

Once I open global search, I see a list of results starting with "Livingston Island", North Pole, etc.... - shouldn't this be empty?

maybe not empty but filled with last visited area / downloaded areas favorites .... but not the global index

bkucsera commented 3 years ago

Search is now by default global which is nice. I have 2 things that (still) confuse me:

  1. Now when I click search in an area it obviously searches only in that area which makes sense. But how do i search globally from there? Right now I have to click "back" (arrive on the map), click back again (arrive on area page), click back again (arrive on the map with the area selected), click search on top right - now I can finally search globally - I think there should be a shorter way
  2. Once I open global search, I see a list of results starting with "Livingston Island", North Pole, etc.... - shouldn't this be empty?

@bkucsera please check / comment

  1. What if we make the Topo Guru logo clickable at the upper left corner? If the user clicks on it, we drop back to the main search page. Or do you have other ideas? In the next version the menu will be in the footer, as we checked during the last call. What if we solve this issue there, with double clicking on the Search icon is reseting the Search menu?

  2. Here the default setting will be Countries, so it will always start with the country list, by alphabetical order. I think its better to have the nodes here, so the users can start browsing, not only search for an item.

bkucsera commented 3 years ago

the "local" search is not so user friendly at the moment. the grade filter (slider) triggers a tab swipe. and does not filter the routes on the fly. also open the keyboard and press the search icon does not update the route list according the grade filter.

furthermore i would propose that the "route tab" within the local search is pre-selected if there are routes. for filtering routes what might be the most common local search you have to switch to the "route-tab" first. also it looks like that the route search is using an api call. but the on devise instant filtering while typing would be more offline friendly and faster. as the data is already available. you can trigger a api search if in the soft keyboard the looking glass is pressed.

Grade filter slider is a bug, we fix it. Thanks for it! Route search: we already use offline search, if the selected node has been opened earlier, so we have the meta data on the device. This is why it can work in offline as well. starting with route tab: we fix it in the 2nd release, good idea!

rouletout commented 3 years ago

Solved in 153 - default view is countries. Closing.