nicbet / docker-phoenix

A dockerized Phoenix development and runtime environment.
GNU General Public License v3.0
277 stars 57 forks source link

Extend script runners #15

Closed ravloony closed 4 years ago

ravloony commented 5 years ago

I extended the script runners to:

nicbet commented 5 years ago

@ravloony Thanks for the PR! I really like the consolidation of mix to call run, and the added npm shortcut.

As for the permissions fix in the run script, I believe a better way around this would be to either map UIDs in the container to match or build the container with the proper UIDs. My past experience with chown on the docker file system is incredibly disruptive (creates a new layer for each changed file/permission) and really slow in the long run.

https://jtreminio.com/blog/running-docker-containers-as-current-host-user/ Has some fantastic discussion around the issue.