search

nicbou / markdown-notes

A note-taking application that supports Markdown, LaTeX and more. Not actively maintained.
http://markdownnotes.com
Creative Commons Zero v1.0 Universal
106 stars 12 forks source link

"Remember Me" doesn't work with some password managers #55

Open ghost opened 7 years ago

ghost commented 7 years ago

With some Password Managers, users are unable to stay logged in by checking the "Remember Me" checkbox on the login form. A simple fix would be to set the box to be true by default.

AuHau commented 7 years ago

Well to be honest, I don't like the proposed fix. From UX perspective the current behavior makes more sense...

Can you give us more details? What password managers? I use for example Last Pass and I have no issue with Remember Me feature...

ghost commented 7 years ago

I use 1Password on the latest version of FireFox (OSX El Capitan). Could you please elaborate more on why you feel the current behaviour makes more sense? Also, a friend of mine who uses MarkDown notes as well mentioned this issue to me, I'm not too sure which PWM he uses, but I'll ping him and ask. 

nicbou commented 7 years ago

I'm with @AuHau here. If we change behaviour, it should be for a good reason. You should try playing with the input name and attributes before changing behaviour. Perhaps your password manager will see a different input name better, for instance.

AuHau commented 7 years ago

The issue I see, is that currently user has to check "Remember me" only once, when he wants to stay logged in, but if some user does not want to stay logged in (eq. public computer), then with your proposed solution he might forget to uncheck the Remember me & forget to log out manually and then his notes can be easily compromised (in case of public computer). Moreover when comes to this feature the "standard" is to have it by default unchecked...

ghost commented 7 years ago

In hindsight, a quick and easy fix probably wasn't the brightest of ideas. I'll do a bit more phishing around to find a better solution.