niccokunzmann / first_timer_scraper

Find pull-requests and issues of first time contributors
http://firsttimers.quelltext.eu
GNU Affero General Public License v3.0
9 stars 15 forks source link

Make the API public to JavaScript #11

Closed niccokunzmann closed 6 years ago

niccokunzmann commented 7 years ago

Set the headers for

Access-Control-Allow-Origin: *

for every JSON response

niccokunzmann commented 7 years ago

@Tompage1994 The response you edited in #17 is a cached response from github. The implementation would be in app.py to make it usable by JavaScript. I am sorry I did not write it down. Here is the current response: grafik There we need your header to make the API public to JavaScript.

The code looks good to me and could be copied over. What do you think?

niccokunzmann commented 7 years ago

Also, in some places we return JSON. Examples:

Everywhere where we test for ending == "json", we could use the open API for web-sites.

niccokunzmann commented 6 years ago

Closed in #27