niccokunzmann / first_timer_scraper

Find pull-requests and issues of first time contributors
http://firsttimers.quelltext.eu
GNU Affero General Public License v3.0
9 stars 15 forks source link

style the pages #8

Open niccokunzmann opened 7 years ago

niccokunzmann commented 7 years ago

All pages in the static and the templates directory only use HTML. there is notstyling. Therefore:

abishekvashok commented 7 years ago

Want help?

niccokunzmann commented 7 years ago

sure! :)

abishekvashok commented 7 years ago

Material design?

niccokunzmann commented 7 years ago

You can design as you like. I do not have any style ideas.

Material design?

I do not know what you mean.

abishekvashok commented 7 years ago

You answered me :) and gave me freedom :)

nadia39 commented 7 years ago

Is there already somebody assigned to this issue?

niccokunzmann commented 7 years ago

@nadia39, @Abhi2424shek wanted to work on this but this does not exclude that you work on it. If you like, you can add small improvements. If you let us know here, what you are working on, I think, the conflicts will be small.

abishekvashok commented 7 years ago

@nadia39 feel free to work on it, I will help you by side.

nadia39 commented 7 years ago

I will add the stylesheet to all the html files you can make it look good? @Abhi2424shek

nadia39 commented 7 years ago

I created basic .css files however it doesn't allow uploads on this repository... @niccokunzmann Could you allow uploads, if not then @Abhi2424shek- you can add the corresponding .css files later on if you have already started on them.

I only added the stylesheet link on the .html pages instead

niccokunzmann commented 7 years ago

@nadia39 If you try to upload to here, this is not possible. However, you can fork this repository, upload the changes to there and create a pull-request.

This is the general contribution workflow on github. Here is some reading:

You can ask, if you like.

niccokunzmann commented 7 years ago

@nadia39 Great! I believe, there is one minor change to be done so it works.

When you include the CSS you do this:

<link rel="stylesheet" type="text/css" href="add-github-authentication-failure.css">

However, I think, this is required to include them because of the new location:

<link rel="stylesheet" type="text/css" href="/static/add-github-authentication-failure.css">

What do you think?

jinayshah7 commented 7 years ago

screen shot 2017-07-15 at 10 55 42 pm

I've used W3.CSS to style the page and I can do it for all 3 pages if you want, @niccokunzmann. Let me know what you think!

niccokunzmann commented 7 years ago

@jinayshah7 This looks fantastic. If you like to create a pull-request, I would like to merge it.

jinayshah7 commented 7 years ago

Sure @niccokunzmann, I'll submit it before the weekend

nk8 commented 6 years ago

@niccokunzmann Is there more to do on this ticket? I was interested in helping improve the UI, in particular the layout of the page. Should I contribute to this issue or create a new one?

niccokunzmann commented 6 years ago

Welcome, @nk8! #25 introduced styling for the web pages. However, there are some pages which still need styling, I believe:

If you like, you can create new issues and link to this one. However, if you write something here, all people who contributed to improving the UI get informed.