niccokunzmann / mundraub-android

📱Android App for Mundraub, Na-Ovoce and other fruit maps
https://f-droid.org/en/packages/eu.quelltext.mundraub/
GNU General Public License v3.0
33 stars 22 forks source link

Implement Fruitmap.org sign-in #233

Open aerobil opened 5 years ago

aerobil commented 5 years ago

Hi, thx for the great idea!

I've signed up to fruitmap and managed to login through their interface ; http://fruitmap.sk/login But no way to log in through fruit radar ;"this operation is not yet implemented"

Am I missing something?


We're using Polar.sh so you can upvote and help fund this issue. We receive the funding once the issue is completed & confirmed by you. Thank you in advance for helping prioritize & fund our work.

Fund with Polar

niccokunzmann commented 5 years ago

Hi,

this is absolutely correct.

How does it come to this: Short: I did not want to invest the time myself.

Why: Fruitmap has an undocumented interface for how to log in. It took me 1 week to implement the login and all other operations for mundraub which is also not documented. It took me 1-2 days after this to implement what na-ovoce provides because it is documented and open-source.

What to do about it: The task of of implementing the fruitmap interface is called reverse-engineering, which I also used for mundraub. I looked at what the browser does in the Web Developer/Network Section: Requests and answers and their content. I assume a way like this can be gone with fruitmap.

  1. Post how to log in, sign up, add a fruit, delete a fruit, update a fruit.     e.g. like https://github.com/jsmesami/naovoce/blob/master/API.apib
  2. implement it https://github.com/niccokunzmann/mundraub-android/blob/master/app/src/main/java/eu/quelltext/mundraub/api/FruitMapAPI.java#L19

On 6/17/19 2:32 PM, aerobil wrote:

Hi, thx for the great idea!

I've signed up to fruitmap and managed to login through their interface ; http://fruitmap.sk/login But no way to log in through fruit radar ;"this operation is not yet implemented"

Am I missing something?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/niccokunzmann/mundraub-android/issues/233?email_source=notifications&email_token=AAEJ4IGU66V2SRLML3QFW2LP2577PA5CNFSM4HYWFKYKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZ34HPQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEJ4IEVJR4XY66UYDJ7KMDP2577PANCNFSM4HYWFKYA.

niccokunzmann commented 5 years ago

I will help concerning the understanding of my code. I will not do the reverse-engineering part of the API. Related issue: https://github.com/niccokunzmann/mundraub-android/issues/181