search

niccokunzmann / python_dhcp_server

a dhcp server in python
MIT License
89 stars 32 forks source link

allow 172.16. .... and 10. ... ip address ranges #6

Open niccokunzmann opened 8 years ago

niccokunzmann commented 8 years ago

the address ranges should be fully exploitable

vitormhenrique commented 5 years ago

Nicco, do you remember where in the code this limitation exists? I'll try to fix this... not really sure if I'll be capable but...

niccokunzmann commented 5 years ago

https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcp.py#L182 https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcp.py#L462 https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcp.py#L481 https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcp.py#L262 https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcp.py#L227

To me it seems like the address ranges should be fully usable from this code.

However, I read this:

https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcpgui.conf#L22

this line only skips the first 5.

https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcp.py#L255

So, the range can not be changed directly but it rather fills the subnet mask range.

niccokunzmann commented 5 years ago

I think, this can be closed because the issue is gone. But, if you like, you can check. What do you think?