search

nice-registry / nice-package

📦 Clean up messy package metadata from the npm registry
35 stars 7 forks source link

sanitize packages with a valid property #12

Closed zeke closed 8 years ago

zeke commented 8 years ago

Was getting this bug for packages that have a valid property set in their package.json:

/Users/zeke/zeke/package-stream/node_modules/nice-package/index.js:10
    Object.assign(this, pkg)
           ^

TypeError: Cannot set property valid of #<Package> which has only a getter
    at new Package (/Users/zeke/zeke/package-stream/node_modules/nice-package/index.js:10:12)
    at ChangesStream.<anonymous> (/Users/zeke/zeke/package-stream/index.js:25:17)
    at emitOne (events.js:96:13)
    at ChangesStream.emit (events.js:188:7)
    at ChangesStream.<anonymous> (/Users/zeke/zeke/package-stream/node_modules/readable-stream/lib/_stream_readable.js:786:14)
    at emitNone (events.js:86:13)
    at ChangesStream.emit (events.js:185:7)
    at emitReadable_ (/Users/zeke/zeke/package-stream/node_modules/readable-stream/lib/_stream_readable.js:448:10)
    at emitReadable (/Users/zeke/zeke/package-stream/node_modules/readable-stream/lib/_stream_readable.js:444:5)
    at readableAddChunk (/Users/zeke/zeke/package-stream/node_modules/readable-stream/lib/_stream_readable.js:187:9)