niceandgoodonline / Liquid-In-Mesh-Shader-Demo-Godot

Creative Commons Zero v1.0 Universal
4 stars 1 forks source link

Not working on GTX3060, Windows 10, Godot 4.1.3 stable. #1

Open Conz3D opened 8 months ago

Conz3D commented 8 months ago

Specs: Godot Engine v4.1.3.stable Forward+ NVIDIA GeForce RTX 3060 Windows 10

In the demo project, I can see the liquids in the editor, but not in runtime. I get no error msg in the Output. Editor: grafik Runtime: grafik

There is some up moving noise in the sphere. Are these the bubbles? The level of the liquid is missing, the shapes are 100% filled. Do I have to adjust anything else in the demo to work?

niceandgoodonline commented 8 months ago

hey!

Thanks for bringing my attention to this bug. It had to do with a last minute "optimization" I did but didn't test properly! I pushed the fix, so you can pull the latest version or fix line 31 in the MinimalLiquidSimulation.gd script (the spatial activity script, not the shader) to read:

coeff = (-springConstant * coeff_old - reaction * accell) / 3600.0 + 2 * coeff_old - coeff_old_old - delta * dampening * (coeff_old - coeff_old_old)