niceandserious / crafty-vagrant

A boilerplate dev environment for jump-starting Craft CMS projects
MIT License
57 stars 13 forks source link

Feature/php7.0 #33

Closed nickautomatic closed 6 years ago

nickautomatic commented 7 years ago

@marcellegane @peterlarkin Hope you're both well! Opening a PR because this branch (PHP7) is working fine for me on VirtualBox 5.1, but I know you both had trouble with it. My best guess is that was a VirtualBox version issue (you were both on 5.0). If you try updating to 5.1 and find this branch works, then I reckon it should be ok to merge into master (might be worth adding a version number to VirtualBox in the requirements section of the README at the same time).

peterlarkin commented 7 years ago

I haven't had a chance to fully try this yet, I'll see if I can spin up a test over the next week. I know @marcellegane did try to set up a new project with this in the last couple of weeks and still ran into some problems though

ow commented 7 years ago

Hey @nickautomatic I'd love to help test this if I can with my existing project - is there an upgrade path from existing instances of crafty-vagrant?

nickautomatic commented 7 years ago

@ow Thanks for the offer! If you'd like to test this branch and let us know if it works for you that would be great. I'm afraid there's no specific upgrade path though: we really built Crafty as a quick starting point for new projects, so we've rarely needed to port subsequent Crafty updates back into pre-existing projects.

Having said that, it might be possible to upgrade to a new version of Crafty by doing something along the following lines:

Alternatively, clone Crafty to a new folder, install as usual, and then try a git pull from your existing project followed by a db restore (I haven't tried this approach, but it might conceivably work...)

I don't know whether either approach will work though, so please proceed with caution, keep backups and do this at your own risk!

ow commented 7 years ago

@nickautomatic followed your instructions and the upgrade went without a single hitch. Craft performance on PHP7 is clearly better — not perfect, but I blame dev mode — and I'm much happier! I'm running Windows 10 here, but as I said, it was smooth sailing.

nickautomatic commented 7 years ago

@ow Glad to hear it worked! Out of interest:

ow commented 7 years ago

Hey @nickautomatic I'm on VirtualBox 5.1 already, and it works fine there! I used your first set of steps, which worked fine. I had changed my origin so needed to set another remote to pull the changes, but everything merged cleanly — and I didn't even need to restore my database since the latest dump was in my folder and the bootstrap script imported it 👍