search

niceboygithub / AqaraSmartSwitchS1E

Everything about Aqara Smart Switch S1E
Apache License 2.0
123 stars 14 forks source link

trim quote when reading parameters in dpf.conf to make frame.sh work #32

Closed waterlou closed 2 weeks ago

waterlou commented 3 weeks ago

Try to use frame.sh, dpf.conf is stored as json. the frame.sh script use simple jshon to parse the parameters, but DPF_PHOTOS_URL and DPF_PHOTOS was parsed without removing the quote from the json. that make the concatenation of path in function get_picture not working.

Added 3 seoconds delay in frame.sh, when digital_frame is enabled in dpf.conf, and restart the device, you will find that frame.sh is not started. Turn out it's caused by read_current_theme function that likely the ubus function exited the script. It may caused by ubus is not ready in post_init.sh. Sleep for 3 seconds fixed the problem,

waterlou commented 3 weeks ago

Is it better to move the scripts as a source code in the repo instead of inside the zip file?

niceboygithub commented 2 weeks ago

No developer interest to develop. Tar file is enough for users.