search

nicebyte / nicegraf

An abstraction layer for graphics APIs.
198 stars 13 forks source link

Use MSVC over WIN32 for selecting compiler options #190

Closed OttoHatt closed 11 months ago

OttoHatt commented 11 months ago

Allows using GCC & Clang on Windows.

OttoHatt commented 11 months ago

Treating warnings as errors means Nicegraf doesn't compile under GCC w/ Mingw64. Regardless, this is more correct.

nicebyte commented 11 months ago

i don't mind taking this specific pr, but note that the only compiler supported by nicegraf on windows is msvc. we don't build or test with anything other than msvc on windows. we may also use msvc-specific extensions on windows (don't think it's the case right now, but we "reserve the right", so to speak).

nicebyte commented 11 months ago

please rebase your branch on the repo's master so that the CI checks may run.

OttoHatt commented 11 months ago

Couldn't rebase on the web client (hope squashing the commits is acceptable)