search

nicehash / NiceHashMiner-Archived

NiceHash easy to use CPU&GPU Miner
843 stars 326 forks source link

VS2017 source code upgrade / .Net target framework > 4.5 #1022

Open SergeySypalo opened 7 years ago

SergeySypalo commented 7 years ago

Hi guys, I'm trying to compile NiceHash miner using Visual Studio 2017 and .NetFramework 4.7 but getting compilation errors. Main reason why I didn't use complied version because it's requires .NetFramework 3.5 which contains security bugs and not installed by default in Windows 10. So Is it possible for you to move to .NetFramework 4.5 at least for the target framework, or preferably to .NetStandard 2.0 so it will make NiceHashMiner cross pltform. And thank you for makng such nice software.

Squall-Leonhart commented 7 years ago

all .net versions have security bugs, microsoft adressess any issues in 3.x with same biweekly fixes that they address 4.x issues.

SergeySypalo commented 7 years ago

Hi Squall-Leonhart, Thx for the response, so there are no plans to upgrade to newer target framework? I was able to compile the source code, just removed AMD checker depedency (as I'm on NVidia cards) there were only errors related to ambigious Tuple variable types and some Hash tables. Then just copied with overwrite compiled project to the downloaded version based on 2.x framework. And that did the trick, as NVidia checker project wasn't able to load in VS2017 (I guess because of CUDA SDK dependency which isn't installed on my machine). That's a dirty workaraund for those who don't want to install older .NetFramework 2 & 3.5

Squall-Leonhart commented 7 years ago

I have no idea what the developers plans are, I was just quashing the notion that dot net 4.x is safer than 3.x