nicehash / excavator

NiceHash's proprietary low-level CUDA miner
https://www.nicehash.com
53 stars 19 forks source link

1.5 not executing event on_quit #246

Closed EvgeniyKorepov closed 3 years ago

EvgeniyKorepov commented 6 years ago

Has noticed that 1.5 began to fall at closing windows or completion on Control + C. It seems to me that the quit event does not start {"event":"on_quit","commands":[ {"id":1,"method":"device.set.tdp","params": ["0","100"]}, {"id":1,"method":"device.set.core_delta","params": ["0","0"]}, {"id":1,"method":"device.set.memory_delta","params":["0","0"]} ]} In the logs of the event, I do not see

t4nja commented 6 years ago

It works for me when closing with Control + C. You can add message command inside on_quit event for easier debugging: {"id":1,"method":"message","params":["Executing quit commands."]}

Are you sure it doesn't work? Can you check again please?

EvgeniyKorepov commented 6 years ago

@dropky Added, the command is executed. So I was wrong. But the completion of 1.5 stably on different farms leads to a crash of the driver or the operating system. Does not depend on the current algorithm. Maybe a coincidence ...

P.S. I will add - the completion of 1.5 by a remote command "quit" does not lead to crash (it is completed correctly)

t4nja commented 6 years ago

But the completion of 1.5 stably on different farms leads to a crash of the driver or the operating system.

How are you quitting excavator in this case? Force quit? As I understand if you use quit command everything works fine? No crashes?

EvgeniyKorepov commented 6 years ago

To close, I use the quit command via API. Unfortunately my request for an quit with a parameter is not implemented yet, we have to manually hang the execution of the cmd-file (over remote VNC viewer). There are no crashes with this approach, everything ends well. When closing through Control + C or closing a window, in most cases I get a driver crash or OS crash

t4nja commented 6 years ago

What version of driver do you have?

EvgeniyKorepov commented 6 years ago
t4nja commented 6 years ago

Hm, I have 390.65 driver and can't reproduce the problem. I'll test it some more.

EvgeniyKorepov commented 6 years ago

I forgot to mention the initial state of the excavator before going out - working algorithm with overclocking of GPU. For example lyra2rev2 on GTX 1080 Ti TDP/CoreDelta/MemoryDelta = 120/180/-1000 - The problem is reproduced in 70% of cases. In version 1.4.x - the application closes correctly. It's very strange, except for the version of the Excavator nothing changes.

nicehashdev commented 3 years ago

This works. Closing.