Closed wcornwell closed 2 years ago
favicon - is this the icon in the browser bar?
yup
Looks straight forward, just put in static folder.
https://stackoverflow.com/questions/42043648/where-do-i-put-my-favicon-with-hugo
Is it this file? https://github.com/cornwell-lab-unsw/EnvironmentalComputing/blob/master/E_C_Logo_black_square-300x265.png
Is there a way to access the old website? I am trying to see what favicons we had there? I think we can delete https://github.com/cornwell-lab-unsw/EnvironmentalComputing/blob/master/E_C_Logo_black_square-300x265.png, it used to be in the README but we have a new and improve logo now!
I managed to do it!! Had to add back in header.html and favicon.html!
Awesome! Alas not showing here yet. Is it showing in your browser?
Latest commit didn't deploy successfully?
It is deployed on me end!? But as I said in slack, for some reason layouts/partials didn't push to the repo! I will add this manually via Github itself.
This appears to be the issue, the favicon.html file is greyed out!
No idea why the favicon is not showing up now that everything needed is in the repo (favicon.html, header.html, favicon.png)!
The mystery continues and sounds like it may have to do with netilify: https://answers.netlify.com/t/favicon-not-showing-on-netlify/16349/6
@dfalster do you mind trying to downloading the deploy to check if it contains the favicon files?: https://docs.netlify.com/site-deploys/manage-deploys/#download-a-deploy
Otherwise we can try this:
Working locally on my machine
But not on any of the netlify sites
@fontikar I've booked over the code and can't fault it.
Also, the favicon image is on the server. You can access directly via https://environmentalcomputing.net/images/favicon.png
And just to check, i downloaded the deploy to check what was in there (good tip BTW)
The file is in there
As is the links
Bummer, I'm stumped! I will post to that thread and see how where it lands! Thanks for all the checks @dfalster :)
And just to check, i downloaded the deploy to check what was in there (good tip BTW)
The file is in there
As is the links
Actually @dfalster how about partials files? Do you mind having a look in layouts/partials/ and see if header.html and favicon.html is there? Those are the partials that call on images/favicon! From which file is the second screenshot taken?
Hi @fontikar - at the end of the deploy stage, each page has by now been rendered into a standalone page. So all the partials and theme stuff is gone.
So you shouldn't have partials there.
My point about is that if you look in the html files, you see the partial has done its work. The appropriate (I think) code has been inserted into each page for the page icon, exactly where the favicon partial would place it.
Can you both confirm you can see the favicon? It appears to be working now?!
https://answers.netlify.com/t/favicon-not-showing-on-netlify/16349/18
Yes, it's there, nice one!!! Did you change anything?
No no I suppose there maybe a lag to get things on a server?!
done
should migrate this over somehow