nicercode / EnvironmentalComputing

These are the R markdown files used to generate
http://environmentalcomputing.net/
Creative Commons Attribution 4.0 International
16 stars 5 forks source link

favicon #35

Closed wcornwell closed 2 years ago

wcornwell commented 2 years ago

should migrate this over somehow

dfalster commented 2 years ago

favicon - is this the icon in the browser bar?

wcornwell commented 2 years ago

yup

dfalster commented 2 years ago

Looks straight forward, just put in static folder.

https://stackoverflow.com/questions/42043648/where-do-i-put-my-favicon-with-hugo

Is it this file? https://github.com/cornwell-lab-unsw/EnvironmentalComputing/blob/master/E_C_Logo_black_square-300x265.png

fontikar commented 2 years ago

Is there a way to access the old website? I am trying to see what favicons we had there? I think we can delete https://github.com/cornwell-lab-unsw/EnvironmentalComputing/blob/master/E_C_Logo_black_square-300x265.png, it used to be in the README but we have a new and improve logo now!

fontikar commented 2 years ago

Screen Shot 2022-02-08 at 11 48 24 am I managed to do it!! Had to add back in header.html and favicon.html!

dfalster commented 2 years ago

Awesome! Alas not showing here yet. Is it showing in your browser?

wcornwell commented 2 years ago

Latest commit didn't deploy successfully?

fontikar commented 2 years ago
Screen Shot 2022-02-09 at 9 17 30 am

It is deployed on me end!? But as I said in slack, for some reason layouts/partials didn't push to the repo! I will add this manually via Github itself.

fontikar commented 2 years ago
Screen Shot 2022-02-09 at 9 35 01 am

This appears to be the issue, the favicon.html file is greyed out!

fontikar commented 2 years ago

No idea why the favicon is not showing up now that everything needed is in the repo (favicon.html, header.html, favicon.png)!

fontikar commented 2 years ago

The mystery continues and sounds like it may have to do with netilify: https://answers.netlify.com/t/favicon-not-showing-on-netlify/16349/6

@dfalster do you mind trying to downloading the deploy to check if it contains the favicon files?: https://docs.netlify.com/site-deploys/manage-deploys/#download-a-deploy

Otherwise we can try this: Screen Shot 2022-02-09 at 12 11 48 pm

dfalster commented 2 years ago

Working locally on my machine

image

But not on any of the netlify sites

@fontikar I've booked over the code and can't fault it.

Also, the favicon image is on the server. You can access directly via https://environmentalcomputing.net/images/favicon.png

dfalster commented 2 years ago

And just to check, i downloaded the deploy to check what was in there (good tip BTW)

The file is in there image

As is the links

image

fontikar commented 2 years ago

Bummer, I'm stumped! I will post to that thread and see how where it lands! Thanks for all the checks @dfalster :)

fontikar commented 2 years ago

And just to check, i downloaded the deploy to check what was in there (good tip BTW)

The file is in there image

As is the links

image

Actually @dfalster how about partials files? Do you mind having a look in layouts/partials/ and see if header.html and favicon.html is there? Those are the partials that call on images/favicon! From which file is the second screenshot taken?

dfalster commented 2 years ago

Hi @fontikar - at the end of the deploy stage, each page has by now been rendered into a standalone page. So all the partials and theme stuff is gone.

So you shouldn't have partials there.

My point about is that if you look in the html files, you see the partial has done its work. The appropriate (I think) code has been inserted into each page for the page icon, exactly where the favicon partial would place it.

fontikar commented 2 years ago

Can you both confirm you can see the favicon? It appears to be working now?!

https://answers.netlify.com/t/favicon-not-showing-on-netlify/16349/18

dfalster commented 2 years ago

Yes, it's there, nice one!!! Did you change anything?

fontikar commented 2 years ago

No no I suppose there maybe a lag to get things on a server?!

wcornwell commented 2 years ago

done