search

nicercode / EnvironmentalComputing

These are the R markdown files used to generate
http://environmentalcomputing.net/
Creative Commons Attribution 4.0 International
16 stars 5 forks source link

Mistake found: google analytics broken #36

Closed wcornwell closed 2 years ago

wcornwell commented 2 years ago

Which page(s) do this mistake(s) pertain to? All

Describe the error(s) Google analytics broken

Additional context the two different partials/header.html files seem to not be playing nicely together.

dfalster commented 2 years ago

On Netlify, I downloaded the deployment from Feb 4 (commit 1db7d10) and Feb 9(commit 9447b0b) and then compared them using git to see if there were any differences. Indeed it seems all the google analytics stuff has been removed

image

I'll now look at the code to see if I can figure out why

dfalster commented 2 years ago

Here's the code comparison

https://github.com/nicercode/EnvironmentalComputing/compare/1db7d10...9447b0b

The issue is (as Will suggested) addition of new page layouts/partials/header.html This overrides the one in themes/hugo-theme-learn/layouts/partials/header.html. But that is where we added the google analytics code in https://github.com/nicercode/EnvironmentalComputing/commit/ca84bf596b59376d4c23a94926f773e1c5541785 (#21).

It's actually good to keep our own copy of the partials so I'll just add google analytics back in (see d7ba9c7)

dfalster commented 2 years ago

I now have access to analytics (thanks @wcornwell ) and seems to be working.