search

nicferrier / elnode

evented io webserver right inside your emacs.
http://nicferrier.github.com/elnode
GNU General Public License v3.0
477 stars 49 forks source link

Make Elnode work on Emacs 26.1 #107

Closed jcaw closed 5 years ago

jcaw commented 5 years ago

Elnode doesn't work on Emacs 26.1, because in make-network-process, :nowait and :server can no longer be true simultaneously. Add a cautious fix for this, which flips :nowait to nil on Emacs 26.1 upwards.

This fix should be safe. It's the same method used by emacs-web-server to fix the same bug. Digging around, Emacs 25 ignores :nowait when server it t. Emacs 26.1 just formalises this, by throwing an error.

Fixes #106 Closes #105

Initially I thought Emacs 25.1+ was broken, but it looks like this isn't the case - it seems to be exclusive to Emacs 26.1+.

jcaw commented 5 years ago

Closing due to MELPA updating their recipe: melpa/melpa#6184

Active fork here: https://github.com/jcaw/elnode