search

nicferrier / marmalade

Nic's clone of nex3's original marmalade. Nic is maintaining this now and updating this repo.
http://marmalade-repo.org
GNU General Public License v3.0
32 stars 8 forks source link

A few Header and Footer issues #32

Closed jlf closed 10 years ago

jlf commented 11 years ago

I noticed a few issues with the text and targets of links in the footer: 1) The target of the 'Code' link in the footer s currently http://code.google.com/p/marmalade but should be the github repo. 2) On package detail pages such as http://marmalade-repo.org/packages/creole , users may assume the footer links refer to the package being viewed instead of Marmalade itself. It would be better for the link text to contain `Marmalade' to make this clearer. 3) The footer currently appears immediately after the main content of the page. It would be better for it to consistently appear at the bottom of the window. 4) The header content ("Marmalade", "Spreadable Elisp", and "Sign In"/"Sign Up"/Search) moves horizontally when text scale is changed in the browser. The content on the right hand side can even move out of the visible window entirely at higher zoom levels (observed in Chrome 23.0.1271.101 for OSX). It would be better to pin this content to the left, center, and right of the browser window regardless of zoom level.

nicferrier commented 11 years ago
  1. I have fixed.
  2. we currently can't have separate footers for package pages
  3. is actually quite difficult to do generally, with CSS. One can tie something to the bottom of the viewport but that makes everything else scroll behind it which is not what you're suggesting I think... one can fix the height of the page, but that's not right either... one can add a constant buffer between the body and the footer... but that's not right either. If you know how to do it do let me know.
  4. again needs significant design change I think, good idea but not possible until I have a rewrite.