nicferrier / marmalade

Nic's clone of nex3's original marmalade. Nic is maintaining this now and updating this repo.
http://marmalade-repo.org
GNU General Public License v3.0
32 stars 8 forks source link

Version header should accept more than numbers separated by dots #33

Open fsmunoz opened 11 years ago

fsmunoz commented 11 years ago

Description

When uploading e.g. aes.el, which has a Version: header of "0.5beta1", Marmalade returns this error:

Parsing error: Version "0.5beta1" must contain only numbers separated by dots.

The documentation seems to indicate that the accepted value should be something thar (version-to-list) can parse, as per the docs (http://www.gnu.org/software/emacs/manual/html_node/elisp/Library-Headers.html#Library-Headers)

"If ‘Version’ is not suitable for use by the package manager, then a package can define ‘Package-Version’; it will be used instead. This is handy if ‘Version’ is an RCS id or something else that cannot be parsed by version-to-list"

Since the above Version is parseable by version-to-list my understanding is that it should be acceptable.

What steps will reproduce the problem?

  1. Upload Emacs Lisp file with a Version: header containing letters, in a way that is parseable by (version-to-list)
  2. An error is returned complaining about the presence of letters

    What is the expected output? What do you see instead?

The expected output would be for the file to be accepted.

What version of the product are you using? On what operating system?

N/A, but GNU/Linux (RHEL 6.3 Workstation) is the OS of the client, with the browser being Chrome.