nicferrier / marmalade

Nic's clone of nex3's original marmalade. Nic is maintaining this now and updating this repo.
http://marmalade-repo.org
GNU General Public License v3.0
32 stars 8 forks source link

Better package upload error messages #48

Closed mcandre closed 9 years ago

mcandre commented 11 years ago

502 Bad Gateway could be replaced by more specific error messages, encouraging package contributors to improve their formatting.

nicferrier commented 11 years ago

Again, this is something I hope to fix in the new version.

I could do with help there though.

This is the upload:

https://github.com/nicferrier/elmarmalade/blob/master/marmalade-service.el#L150

which calls this:

https://github.com/nicferrier/elmarmalade/blob/master/marmalade-service.el#L121

which makes a temp file and puts the package data in it and then uses this to get the package path:

https://github.com/nicferrier/elmarmalade/blob/master/marmalade-service.el#L121

which uses this to get the meta data of the existing (temp) package file:

https://github.com/nicferrier/elmarmalade/blob/master/marmalade-service.el#L67

and that, I think, is where a lot of error checking needs to be done and reported from.

nicferrier commented 9 years ago

pretty much done.

of course 24.4 breaks it all over again. sigh.