search

nicfit / eyeD3

eyeD3 is a Python module and command line program for processing ID3 tags. Information about mp3 files (i.e bit rate, sample frequency, play time, etc.) is also provided. The formats supported are ID3v1 (1.0/1.1) and ID3v2 (2.3/2.4).
http://eyed3.nicfit.net/
GNU General Public License v3.0
532 stars 58 forks source link

encode chapter related ids from str to bytes #550

Open zvodd opened 2 years ago

zvodd commented 2 years ago

Don't pull. This was my work around but may offer some insight into a pain point. But I don't think it solves the underlying issues.

When trying to run examples/chapters.py I was hitting errors like TypeError: can only concatenate str (not "bytes") to str and the like. I think the real issue is maybe the example is out dated and need to be passing in byte strings instead of strings. or that the utils/requireBytes decorator should be applied more thoroughly to the ChapterFrame and TocFrame constructors.

nicfit commented 2 years ago

Hi @zvodd , thanks for the patches. Not sure if you checked out the chapters branch but I'd be curious whether the same problems occur there. The changes can be seen in https://github.com/nicfit/eyeD3/pull/531 . And any chapter PRs should target that branch.