nicford / Movilytics

Welcome to our website Movylitics, a Sophisticated GroupLens dataset and tmdb analytics exploration tool.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Missing country iso in country_info.csv #15

Closed SteveLim99 closed 3 years ago

SteveLim99 commented 3 years ago

Some country iso codes are not present in the country_info.csv, an example of a missing iso code is as seen below

image

Please note that there are 250 country iso codes whereas only 105 are present in country_info.csv

SteveLim99 commented 3 years ago

ISO code ingested into db, most notable change is the iso code for the czech republic.

XC -> CZ

kimdanny commented 3 years ago

In the csv, we have CZ for Czech Republic, XC for Czechoslovakia and SK for Slovakia. I think this is correct? Please check.

Reason why we have only 106 countries not 250 is because we retrieved country id while iterating through tmbdid and sending API request with that id. However, I do agree that we should have whole 250 countries in our db for future movies from other countries. @SteveLim99

kimdanny commented 3 years ago

@SteveLim99 I just checked all the occurrences of XC, all the movies were made before 1993, where Czech and Slovakia are not yet separated. So XC and CZ are valid, I guess

SteveLim99 commented 3 years ago

Its alright I realize that earlier when loading the movies so the countries that don't exist anymore has been re-added to the csv and the database. Either ways, some countries were still missing since there were only about 105 entry in that csv file so I have added the rest of the countries and their respective iso code as well